Add forward compatible return types - #620
Merged
Merged
Conversation
Open
Member
|
We'll prevent the v1.0.0 branch of our libraries from being installed alongside vspheredb < 1.9.0 if using packages. |
Add bool return type to `isValidEvent()` of `PerfDataConsumerForm` and `VCenterShipMetricsForm` to ensure forward compatibility with ipl-html and ipl-stdlib
lippserd
force-pushed
the
ipl-forward-compatibility
branch
from
June 23, 2026 10:46
f7aed01 to
9a6315d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bool return type to
PerfDataConsumerForm::isValidEvent()andVCenterShipMetricsForm::isValidEventto ensure compatibility with the upcoming strict type additions in ipl-html and ipl-stdlib.